Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Screenscraper integration #1416

Draft
wants to merge 71 commits into
base: master
Choose a base branch
from

Conversation

zurdi15
Copy link
Member

@zurdi15 zurdi15 commented Jan 3, 2025

Description

First iteration of Screenscraper integration. This PR also adds manuals support and in-app pdf viewer for manuals.

Related Issues

Finally closes #212

Checklist

  • I've tested the changes locally
  • I've updated the wiki accordingly
  • I've have updated relevant comments
  • I've assigned reviewers for this PR
  • I've added unit tests that cover the changes
  • All existing tests are passing

Screenshots

image
image
image

TODO:

  • Migration to set Screenscraper platform ID to avoid rescan of all platforms
  • Full platform ids list (thanks @danblu3)
  • Manual uploads from webUI

@zurdi15 zurdi15 added the feature New feature or request label Jan 3, 2025
@zurdi15 zurdi15 self-assigned this Jan 3, 2025
Copy link

github-actions bot commented Jan 3, 2025

Test Results

93 tests   93 ✅  27s ⏱️
 1 suites   0 💤
 1 files     0 ❌

Results for commit 31fcdde.

♻️ This comment has been updated with latest results.

@zurdi15 zurdi15 force-pushed the feature/screenscraper-integration branch from 5f79d1c to 2c6a165 Compare January 3, 2025 11:28
@zurdi15 zurdi15 requested review from adamantike and gantoine and removed request for adamantike February 6, 2025 11:03
@zurdi15 zurdi15 force-pushed the feature/screenscraper-integration branch from 50b1b42 to e08a42d Compare February 6, 2025 22:57
@zurdi15 zurdi15 marked this pull request as draft February 7, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants